Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for next fava release #97

Open
ranebrown opened this issue Nov 27, 2024 · 2 comments
Open

Support for next fava release #97

ranebrown opened this issue Nov 27, 2024 · 2 comments

Comments

@ranebrown
Copy link

Fava has merged support for beancount v3 which I assume means it will be included in the next release. This breaks fava_investor since query functionality was changed (query_shell changed to query). Do you have plans to update before the next fava releae?

Support for Beancount version 3 was added. Using Beancount 2 is still
supported. Beancount query support is now provided by the beanquery package,
which has some minor differences in syntax, the provided columns and functions
to the bean-query functionality in Beancount version 2. For extensions using
Fava's query_shell directly, this will lead to breakage due to differences in
methods and the types that are returned.

@redstreet
Copy link
Owner

Thanks for the heads up! I'd love for fava_investor to stay up to date with all the work around v3. I lack the full bandwidth required right now, so I'd definitely appreciate either a PR or pointers to the specifics of what has changed what needs to be fixed, or anything else at all that might be helpful.

@ranebrown
Copy link
Author

It looks like the execute_query calls would need changed to execute_query_serialised with the return type being a QueryResultTable. The places that use the result of the query would need updated to handle that new return type. I took a look but I couldn't track how calls like this would need changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants