Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the status of the deep effect collection branch? #68

Closed
bdwain opened this issue Jun 21, 2016 · 3 comments
Closed

What is the status of the deep effect collection branch? #68

bdwain opened this issue Jun 21, 2016 · 3 comments

Comments

@bdwain
Copy link
Member

bdwain commented Jun 21, 2016

I was following the thread that the deep effect collection branch was based on initially and I was interested to see what came of it. Are there any plans to do something like that in master?

@lukewestby
Copy link
Contributor

I tried it out in this branch: https://github.com/raisemarketplace/redux-loop/tree/deep_effect_collection

It seems to work okay, but it's a pretty drastic departure from what redux-loop is intended to be so I'd prefer not to release it here and instead let someone else try to build something effective using that method. In particular, I really like how straightforward it is to test a reducer with redux-loop. Gathering effects in this way really changes the testing strategy.

tl;dr redux-loop will not be implementing deep effect collection and will continue to maintain parity with Elm, but this doesn't mean that deep effect collection is a bad idea and if you think it's worthwhile I hope you'll build something great!

@lukewestby
Copy link
Contributor

lukewestby commented Jun 22, 2016

I'm going to close this just so I can keep track of the open issues that represent bugs and things that need to be implemented, but we can definitely continue discussion if you'd like

Labeled as discussion instead

@bdwain
Copy link
Member Author

bdwain commented Jun 22, 2016

Cool. I was asking more out of curiosity. It sounds good in theory but I agree that having to wrap everything in a call to catcheffects or something like that will make testing more difficult. and testing in the return value is super easy.

@bdwain bdwain closed this as completed Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants