Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings make meta a required property #59

Closed
gCardinal opened this issue Apr 21, 2017 · 2 comments
Closed

Typings make meta a required property #59

gCardinal opened this issue Apr 21, 2017 · 2 comments
Labels

Comments

@gCardinal
Copy link

gCardinal commented Apr 21, 2017

Using TypeScript and the included typings makes meta a required property in a FSA.

import {FluxStandardAction as Action} from 'flux-standard-action'
public static updateYear(year: string): Action<string, null>
{
    return {
        type: Actions.SDS_VEHICLE_SELECTION_YEAR_UPDATE,
        payload: year
    }
}

This will complain that meta does not exist in my action. Looking at the typings, I see that meta is no longer optional:

export interface FluxStandardAction<Payload, Meta> {
  /** ... **/
  meta: Meta;  // Notice the lack of ?
}

Is this wanted behavior?

@JaKXz
Copy link
Contributor

JaKXz commented Apr 21, 2017

Please see the discussion in #53. Thanks!

@JaKXz JaKXz added the question label Apr 21, 2017
@JaKXz
Copy link
Contributor

JaKXz commented May 14, 2017

@gCardinal I'm going to close this for now, hopefully your question is answered. If not, feel free to continue the conversation in #53 to keep the context there.

@JaKXz JaKXz closed this as completed May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants