add test cases (#306)

Author: zhuangya

src/handleActions.js

@@ -5,10 +5,7 @@ import isMap from './utils/isMap';
 import ownKeys from './utils/ownKeys';
 import flattenReducerMap from './utils/flattenReducerMap';
 import handleAction from './handleAction';
-
-function get(key, x) {
-  return isMap(x) ? x.get(key) : x[key];
-}
+import get from './utils/get';
 
 export default function handleActions(handlers, defaultState, options = {}) {
   invariant(

src/utils/camelCase.js

@@ -3,9 +3,9 @@ import camelCase from 'to-camel-case';
 const namespacer = '/';
 
 export default type =>
-  type.indexOf(namespacer) === -1
-    ? camelCase(type)
-    : type
+  type.includes(namespacer)
+    ? type
         .split(namespacer)
-        .map(part => camelCase(part))
-        .join(namespacer);
+        .map(camelCase)
+        .join(namespacer)
+    : camelCase(type);

src/utils/flattenWhenNode.js

@@ -1,10 +1,6 @@
 import { DEFAULT_NAMESPACE, ACTION_TYPE_DELIMITER } from '../constants';
-import isMap from './isMap';
 import ownKeys from './ownKeys';
-
-function get(key, x) {
-  return isMap(x) ? x.get(key) : x[key];
-}
+import get from './get';
 
 export default predicate =>
   function flatten(

src/utils/get.js

@@ -0,0 +1,5 @@
+import isMap from './isMap';
+
+export default function get(key, x) {
+  return isMap(x) ? x.get(key) : x[key];
+}

src/utils/unflattenActionCreators.js

@@ -8,8 +8,8 @@ export default function unflattenActionCreators(
 ) {
   function unflatten(
     flatActionType,
-    partialNestedActionCreators = {},
-    partialFlatActionTypePath = []
+    partialNestedActionCreators,
+    partialFlatActionTypePath
   ) {
     const nextNamespace = camelCase(partialFlatActionTypePath.shift());
     if (isEmpty(partialFlatActionTypePath)) {

test/combineActions.test.js

@@ -31,3 +31,9 @@ test('returns a stringifiable object', () => {
     'ACTION_1||ACTION_2||ACTION_3'
   );
 });
+
+test('should throw error if actions is empty', () => {
+  expect(() => combineActions()).toThrow(
+    'Expected action types to be strings, symbols, or action creators'
+  );
+});

test/get.test.js

@@ -0,0 +1,9 @@
+import get from '../src/utils/get';
+
+test('get util helper', () => {
+  const map = new Map([['foo', 'bar']]);
+  const obj = { foo: 'baz' };
+
+  expect(get('foo', map)).toBe('bar');
+  expect(get('foo', obj)).toBe('baz');
+});