Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Q: Should ConnectorDecorator::shouldComponentUpdate consider changes in state slice? #22

Closed
dbrans opened this issue Aug 3, 2015 · 1 comment
Closed

Q: Should ConnectorDecorator::shouldComponentUpdate consider changes in state slice? #22

dbrans opened this issue Aug 3, 2015 · 1 comment

Comments

@dbrans
Copy link

dbrans commented Aug 3, 2015

ConnectorDecorator::shouldComponentUpdate only looks at this.props. What if the result of select(state, this.props) has changed?
https://github.com/gaearon/react-redux/blob/52a280162c220d4ecf1ce826f9dcc423231e8c8b/src/components/createConnectDecorator.js#L13
@dbrans dbrans changed the title Q: Should ConnectionDecorator::shouldComponentUpdate consider changes in state slice? Q: Should ConnectorDecorator::shouldComponentUpdate consider changes in state slice? Aug 3, 2015
@gaearon
Copy link
Contributor

gaearon commented Aug 4, 2015

The changes to the state slice are currently handled by <Connector> it uses internally.
<Connector> is going away (see issue #1 and #16) so this will be more obvious soon.

@gaearon gaearon closed this as completed Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbrans @gaearon