Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with react-redux@^7.0.0 #473

Closed
mnesarco opened this issue May 1, 2019 · 14 comments
Closed

Compatibility with react-redux@^7.0.0 #473

mnesarco opened this issue May 1, 2019 · 14 comments

Comments

@mnesarco
Copy link

mnesarco commented May 1, 2019

I am using react-redux 7.0.3, and there is a dependency problem with redux-devtools:

extract of my package.json:

  "dependencies": {
    "@ant-design/colors": "^3.0.1",
    "@types/jest": "24.0.12",
    "@types/node": "11.13.8",
    "@types/react": "16.8.15",
    "@types/react-dom": "16.8.4",
    "antd": "^3.16.6",
    "react": "^16.8.6",
    "react-dom": "^16.8.6",
    "react-redux": "^7.0.3",
    "react-router-dom": "^5.0.0",
    "react-scripts": "3.0.0",
    "redux": "^4.0.1",
    "typescript": "3.4.5"
  },

  "devDependencies": {
    "redux-devtools": "^3.5.0"
  }


And the problem is:

npm ERR! peer dep missing: react-redux@^4.0.0 || ^5.0.0 || ^6.0.0, required by redux-devtools@3.5.0

@pgoldweic
Copy link

pgoldweic commented May 21, 2019

Similarly, I installed the latest versions of react, redux, react-redux and then redux-devtools, but it gives me a warning possibly equivalent to yours:

redux-devtools@3.5.0 requires a peer of react-redux@^4.0.0 || ^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself

Should I roll back to an earlier version of react-redux in order to use the redux-devtools? (npm installed the latest version of react-redux as of today, 7.0.3) Please advise.

@StephanKuehn
Copy link

Any updates on this?

@benfletcher
Copy link

React-redux is now 7.1.1, do we expect any update to support it? As far as I can tell, everything does work with the latest version, but npm warns on the peer dep version mismatch.

Thanks for any feedback on this!

@lebeier
Copy link

lebeier commented Oct 27, 2019

Any updates?

1 similar comment
@whenmoon
Copy link

Any updates?

@noobjun
Copy link

noobjun commented Nov 13, 2019

any updates?

@Queztion
Copy link

I will have to ask about this too, any updates?

@ZachHappel
Copy link

Having this issue as well.

@venkat-seshadri
Copy link

I am having the same problem

@Queztion
Copy link

There was a comment from Nathan Bierema/Methuselah96 about forking redux-devtools. But now I couldn't find it.

Anybody has ideas why? Or where is it?

@Methuselah96
Copy link
Member

Methuselah96 commented Dec 12, 2019

Yeah, sorry, I have forked redux-devtools and fixed this issue on it and published it as redux-devtools-maintained with the intention of maintaining the package since this package is not actively maintained anymore.

Originally I posted and said that you can now use that using a package alias (e.g. yarn add redux-devtools@npm:redux-devtools-maintained) to make this peer dependency warning go away. The issue is that other packages that have a peer dependency on redux-devtools (e.g. redux-devtools-dock-monitor) will now produce a warning because strictly speaking, redux-devtools is not installed. I deleted the comment on this thread because I'm not sure how helpful the forked package is if it produces another peer dependency warning.

Does anyone know any way to fix this issue? The only real solution I can think of is to fork every package that has a peer dependency on redux-devtools and re-release them under a different package name, but that doesn't seem ideal. Thumbs-up this message if you think I should do that anyway.

@Queztion
Copy link

Hello @Methuselah96 , saw you comments on #502.

I just wanted to ask if your exchange with @timdorr has led to any update to this particular issue?
Thanks!

@Methuselah96
Copy link
Member

@quezath No updates yet.
@timdorr Let me know if there's anything I can do to help move this along.

@timdorr
Copy link
Member

timdorr commented May 4, 2020

Just merged in a PR to add it. We should get it released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests