Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack-dev-server warning: Critical dependency: the request of a dependency is an expression #497

Closed
adamcee opened this issue Jan 22, 2020 · 1 comment · Fixed by #507

Comments

@adamcee
Copy link

adamcee commented Jan 22, 2020

Duplicate of alexkuz/redux-devtools-inspector#68 from the previous version of the repository. If you look at the pull request for the issue linked above you'll see that it was never merged.

Issue:
getting these 2 warnings in webpack bundle:

WARNING in ../~/jsondiffpatch/src/main.js
56:20-50 Critical dependency: the request of a dependency is an expression

WARNING in ../~/jsondiffpatch/src/main.js
61:19-47 Critical dependency: the request of a dependency is an expression

Cause:
The issue is caused by the version of jsondiff currently used. See benjamine/jsondiffpatch#172 and benjamine/jsondiffpatch#76.

Solution:
Update the jsondiffpatch dependency to v0.3.10 or v.0.3.11. Based on benjamine/jsondiffpatch#172 (comment) I am pretty sure this will resolve the issue.

I have a PR for this but don't have contributor permissions and couldn't find a doc w/steps on how to become a contributor : ). But this should be an easy fix for an existing contributor to do.

@adamcee adamcee changed the title Critical dependency: the request of a dependency is an expression Webpack-dev-server warning: Critical dependency: the request of a dependency is an expression Jan 22, 2020
@adamcee
Copy link
Author

adamcee commented May 7, 2020

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant