fix #1156: union return values fall back to allowing only single memb…

…er (#1449)
reduxjs · Sep 3, 2021 · e3bc1fe · e3bc1fe
1 parent 0cd6a2e
commit e3bc1fe
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/toolkit/src/createAsyncThunk.ts b/packages/toolkit/src/createAsyncThunk.ts
@@ -177,7 +177,7 @@ type GetSerializedErrorType<ThunkApiConfig> = ThunkApiConfig extends {
   ? GetSerializedErrorType
   : SerializedError
 
-type MaybePromise<T> = T | Promise<T>
+type MaybePromise<T> = T | Promise<T> | (T extends any ? Promise<T> : never)
 
 /**
  * A type describing the return value of the `payloadCreator` argument to `createAsyncThunk`.

diff --git a/packages/toolkit/src/tests/createAsyncThunk.typetest.ts b/packages/toolkit/src/tests/createAsyncThunk.typetest.ts
@@ -137,6 +137,16 @@ const anyAction = { type: 'foo' } as AnyAction
   expectType<RejectValue>(unwrapResult(returned))
 })()
 
+/**
+ * regression #1156: union return values fall back to allowing only single member
+ */
+;(async () => {
+  const fn = createAsyncThunk('session/isAdmin', async () => {
+    const response: boolean = false
+    return response
+  })
+})()
+
 {
   interface Item {
     name: string