Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in redux docs basic example #1040

Closed
egoist-sx opened this issue Nov 16, 2015 · 1 comment
Closed

Bug in redux docs basic example #1040

egoist-sx opened this issue Nov 16, 2015 · 1 comment
Labels

Comments

@egoist-sx
Copy link

I have just finished reading redux document basics part. There is potentially a bug in basic secion.

If you add three todos, and switch to active filter, click first (which will disappear from list), and you are not able to 'complete' the first todo in those two left.

I think the problem is that in this example code, App only receive todos from 'current selected', and the 'map' function will generate index form this subset of state.todos(the singleton). However, 'COMPLETE_TODO' update index counting in that singleton todos. And there is no way those index matches (other than the case 'SHOW_ALL', as those two lists are equal).

@gaearon
Copy link
Contributor

gaearon commented Nov 16, 2015

This is a duplicate of #795.
Let's discuss there.
We'll fix it eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants