Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build v3.5.2 #1845

Closed
thaggie opened this issue Jul 12, 2016 · 3 comments
Closed

Unable to build v3.5.2 #1845

thaggie opened this issue Jul 12, 2016 · 3 comments

Comments

@thaggie
Copy link

thaggie commented Jul 12, 2016

Environment:

  • node --version -> v6.3.0
  • npm --version -> 3.10.3

Repro steps:

git clone https://github.com/reactjs/redux.git
cd redux
git checkout v3.5.2
npm install

Results:

> redux@3.5.2 build:umd:min /Users/thaggie/dev/deps/redux
> cross-env BABEL_ENV=commonjs NODE_ENV=production webpack src/index.js dist/redux.min.js

Hash: da6adf72cbf2038a3555
Version: webpack 1.13.1
Time: 838ms
       Asset     Size  Chunks             Chunk Names
redux.min.js  6.64 kB       0  [emitted]  main
    + 13 hidden modules
/Users/thaggie/dev/deps/redux/node_modules/jstransform/src/jstransform.js:270
    throw e;
    ^

Error: Parse Error: Line 5: Illegal export declaration
    at throwError (/Users/thaggie/dev/deps/redux/node_modules/jstransform/node_modules/esprima-fb/esprima.js:2823:21)
    at throwErrorTolerant (/Users/thaggie/dev/deps/redux/node_modules/jstransform/node_modules/esprima-fb/esprima.js:2835:24)
    at parseSourceElement (/Users/thaggie/dev/deps/redux/node_modules/jstransform/node_modules/esprima-fb/esprima.js:6432:17)
    at parseProgramElement (/Users/thaggie/dev/deps/redux/node_modules/jstransform/node_modules/esprima-fb/esprima.js:6491:16)
    at parseProgramElements (/Users/thaggie/dev/deps/redux/node_modules/jstransform/node_modules/esprima-fb/esprima.js:6523:29)
    at parseProgram (/Users/thaggie/dev/deps/redux/node_modules/jstransform/node_modules/esprima-fb/esprima.js:6536:16)
    at Object.parse (/Users/thaggie/dev/deps/redux/node_modules/jstransform/node_modules/esprima-fb/esprima.js:7713:23)
    at getAstForSource (/Users/thaggie/dev/deps/redux/node_modules/jstransform/src/jstransform.js:244:21)
    at Object.transform (/Users/thaggie/dev/deps/redux/node_modules/jstransform/src/jstransform.js:267:11)
    at Function.transform (/Users/thaggie/dev/deps/redux/node_modules/es3ify/index.js:108:24)

The actual command that fails is:

node ./build/es3ify
@gaearon
Copy link
Contributor

gaearon commented Jul 12, 2016

Breaking change somewhere? We'd want to kill es3ify anyway and replace it with appropriate Babel plugins.

@SimenB
Copy link
Contributor

SimenB commented Jul 13, 2016

es3ify is removed already (#1688), but wasn't at the time of the last release.
I'm guessing it fails as it globs up es as well (https://github.com/reactjs/redux/blob/v3.5.2/build/es3ify.js#L5). Maybe jstransform was nicer before sophiebits/es3ify#11?

EDIT: Yeah, testing it, es3ify@0.2.1 works, but es3ify@0.2.2 fails. @thaggie, if you want to build, just run npm i es3ify@0.2.1 before running prepublish.

@thaggie
Copy link
Author

thaggie commented Jul 13, 2016

Thanks

@timdorr timdorr closed this as completed Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants