-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: pass this
through bound actionCreator
#2638
Comments
Can you put this together as a PR with some tests to go along with it? |
I'd also like to see some examples of the actual use case for the behavior. I'm not sure if passing through |
I’m sure it isn’t something you want to encourage, but then is it the place of redux to police code quality or rather should it provide a shining example of what can be achieved and then get out of the way. As troubled as it is and as often as it blows up for people, |
@timdorr I haven’t any experience with your testing framework, but I’ll see if I can find some time tomorrow to set it up. Sans tests the PR is one line. |
Is there any chance of changing
bindActionCreator
from:to:
The existing behaviour explicitly sets
this
to undefined so this shouldn't be a breaking change.I have some mixins/decorators that I apply to action creators by composition such that the arguments don't change but I can adjust settings in the enhancer by passing an object through
this
. If I use some of the convenience functions likeconnect
I lose the ability to pass through these objects.The text was updated successfully, but these errors were encountered: