-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using error code strategy employed by react #3655
Comments
Well, it's been 4.5 years and no one has complained yet :) But, I do see your point. It's not a priority for us to work on atm, but if you or someone else would like to put together the infrastructure, we can take a PR. |
@markerikson I think this one can be closed now, right? |
Yep! FYI, I've got |
https://github.com/facebook/react/tree/master/scripts/error-codes
Right now, every production website that uses redux is shipping lengthy error messages that are better suited to development.
Example:
My rough guestimate is that you could reduce the minified version of redux from 6660 characters to more like 4200 characters by replacing these long messages with terse, generated error codes like
throw code(1)
. Seems worth it for potential savings of more than 35%.The text was updated successfully, but these errors were encountered: