-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct typing of createStructuredSelector with multiple sub-selectors #446
Comments
This looks to me to be broken with the latest version of typescript :/ |
Actually I think this is resolved by setting
in |
I'm also experiencing issues with this function's typings. It doesn't work 😢 |
It works for me, but I had to manually specify the types for the generics. If you want to be able to automatically derive these, please have a look at the snippet provided in #476. Hopefully this works for you as well. |
I just published https://github.com/reduxjs/reselect/releases/tag/v4.1.0-alpha.0 , which rewrites the types. If you're still around, could you try it out? |
Should be fixed by #486 . |
Thanks, will check it out! |
@markerikson this is seemingly back with 4.1.7 and TypeScript 4.9.5. Did you want me to create a new issue?
jjH@Jonathons-MBP product-configurator % npm list reselect jjH@Jonathons-MBP product-configurator % npm list typescript
|
@gxpd-jjh : that seems like a very different error than what's listed in this issue. (and tbh, I have no idea what that's even trying to say.) Yeah, file it as a separate issue, although I'm not sure when I'll have time to look at it. |
Hey, it's more like 'help wanted' type of issue as I could not find any information on how to actually do the thing. How do I correctly set type definitions on the following createSelector methods so my custom selector made with createStructuredSelector compiles without errors?
The error is fairly long:
PS. Are there any public repos you might know where devs have used reselect+typescript combo?
The text was updated successfully, but these errors were encountered: