GHA replace ktlint with integrated detekt

Author: mpetuska

.github/workflows/publish_snapshot.yml

@@ -11,30 +11,31 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [macos-latest, windows-latest, ubuntu-latest]
+        os: [ macos-latest, windows-latest, ubuntu-latest ]
 
     steps:
-    - uses: actions/checkout@v2
+      - uses: actions/checkout@v2
 
-    - name: Publish Snapshot
-      env:
-        SONATYPE_NEXUS_USERNAME: ${{ secrets.SONATYPE_NEXUS_USERNAME }}
-        SONATYPE_NEXUS_PASSWORD: ${{ secrets.SONATYPE_NEXUS_PASSWORD }}
-        GPG_SECRET: ${{ secrets.GPG_SECRET }}
-        GPG_SIGNING_PASSWORD: ${{ secrets.GPG_SIGNING_PASSWORD }}
-        SNAPSHOT: 'TRUE'
-      run: ./gradlew publish
-
-    - name: Archive redux-kotlin publications dir
-      uses: actions/upload-artifact@v1
-      with:
-        name: publications-${{ matrix.os }}
-        path: redux-kotlin/build/publications
-
-    - name: Archive redux-kotlin-threadsafe publications dir
-      if: steps.publish.outputsexit_code == 0
-      uses: actions/upload-artifact@v1
-      with:
-        name: publications-threadsafe-${{ matrix.os }}
-        path: redux-kotlin-threadsafe/build/publications
+# Disabling for now, CI will be updated in the followup PR
+#    - name: Publish Snapshot
+#      env:
+#        SONATYPE_NEXUS_USERNAME: ${{ secrets.SONATYPE_NEXUS_USERNAME }}
+#        SONATYPE_NEXUS_PASSWORD: ${{ secrets.SONATYPE_NEXUS_PASSWORD }}
+#        GPG_SECRET: ${{ secrets.GPG_SECRET }}
+#        GPG_SIGNING_PASSWORD: ${{ secrets.GPG_SIGNING_PASSWORD }}
+#        SNAPSHOT: 'TRUE'
+#      run: ./gradlew publish
+#
+#    - name: Archive redux-kotlin publications dir
+#      uses: actions/upload-artifact@v1
+#      with:
+#        name: publications-${{ matrix.os }}
+#        path: redux-kotlin/build/publications
+#
+#    - name: Archive redux-kotlin-threadsafe publications dir
+#      if: steps.publish.outputsexit_code == 0
+#      uses: actions/upload-artifact@v1
+#      with:
+#        name: publications-threadsafe-${{ matrix.os }}
+#        path: redux-kotlin-threadsafe/build/publications
 

.github/workflows/pull_request.yml

@@ -13,14 +13,37 @@ jobs:
     steps:
       - uses: actions/checkout@v2
 
-      - name: Ktlint
-        uses: "vroy/gha-kotlin-linter@v1"
+      - uses: actions/setup-java@v3
+        with:
+          distribution: 'adopt'
+          java-version: 11
+
+      - name: Detekt
+        run: ./gradlew detektAll
+
+      - name: Make artifact location URIs relative
+        if: ${{ always() }}
+        continue-on-error: true
+        run: |
+          ls '${{ github.workspace }}/build/reports/detekt/'
+          cp '${{ github.workspace }}/build/reports/detekt/detekt.sarif' '${{ github.workspace }}/detekt.sarif.json'
+          echo "$(
+            jq --arg github_workspace ${{ github.workspace }} \
+              '. | ( .runs[].results[].locations[].physicalLocation.artifactLocation.uri |= if test($github_workspace) then .[($github_workspace | length | . + 1):] else . end )' \
+              '${{ github.workspace }}/detekt.sarif.json'
+          )" > '${{ github.workspace }}/detekt.sarif.json'
+
+      - uses: github/codeql-action/upload-sarif@v2
+        if: ${{ always() }}
+        with:
+          sarif_file: ${{ github.workspace }}/detekt.sarif.json
+          checkout_path: ${{ github.workspace }}
   test:
     needs: ktlint
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [macos-latest, windows-latest, ubuntu-latest]
+        os: [ macos-latest, windows-latest, ubuntu-latest ]
     steps:
       - uses: actions/checkout@v2
 

build-conventions/src/main/kotlin/convention.common.gradle.kts

@@ -34,12 +34,6 @@ idea {
   }
 }
 
-tasks {
-  withType<Test> {
-//    useJUnitPlatform()
-  }
-}
-
 afterEvaluate {
   tasks {
     if (findByName("compile") == null) {