Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthProvider holds on to expired token until page refresh #1576

Closed
dac09 opened this issue Dec 11, 2020 · 3 comments
Closed

AuthProvider holds on to expired token until page refresh #1576

dac09 opened this issue Dec 11, 2020 · 3 comments
Labels
topic/auth

Comments

@dac09
Copy link
Contributor

dac09 commented Dec 11, 2020 •
edited
Loading

I've noticed this with firebase auth, if you're logged in and don't refresh the page (but can use RW router navigation).

Once the token expires, its not refreshed automatically, as a result graphql calls start to fail.

I suspect this is an issue with other auth providers as well, and we might need to slightly modify the structure of AuthClient to support refresh events.
@dac09 dac09 mentioned this issue Dec 11, 2020
Closed
4 tasks
@dthyresson dthyresson linked a pull request Dec 11, 2020 that will close this issue
wip(auth): Get fresh token before making request #1577
Closed
4 tasks
@dac09
Copy link
Contributor Author

dac09 commented Dec 11, 2020

Duplicates #927

@dac09
Copy link
Contributor Author

dac09 commented Dec 11, 2020

Duplicates #738

This was referenced Jan 7, 2021
Closed
Merged
@dthyresson dthyresson linked a pull request Jan 7, 2021 that will close this issue
Configure ApolloProvider to always use fresh tokens #1609
Merged
3 tasks
@dthyresson dthyresson removed a link to a pull request Jan 7, 2021
Configure ApolloProvider to always use fresh tokens #1609
Merged
3 tasks
@dac09 dac09 mentioned this issue Jan 13, 2021
Closed
7 tasks
@dac09
Copy link
Contributor Author

dac09 commented Feb 8, 2021

Fixed with #1609

@dac09 dac09 closed this as completed Feb 8, 2021
@jtoar jtoar mentioned this issue Jan 31, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wip(auth): Get fresh token before making request dac09/redwood
1 participant
@dac09