Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selections are not necessarily added in order #29

Closed
alecgibson opened this issue Jun 28, 2019 · 1 comment · Fixed by #30
Closed

Selections are not necessarily added in order #29

alecgibson opened this issue Jun 28, 2019 · 1 comment · Fixed by #30

Comments

@alecgibson
Copy link
Collaborator

A selection is broken into multiple span elements. Sometimes, we may want to apply styling to these using :first-child and :last-child CSS selectors. However, the elements are not necessarily added in order (ie I'd expect the top line of a selection to be the first span in the DOM, and so on). This seems to work in order in Chrome by accident, but isn't necessarily the case eg in Firefox.
@alecgibson alecgibson mentioned this issue Jun 28, 2019
Merged
@alecgibson
Copy link
Collaborator Author

Looks like this is due to an upstream issue with RangeFix: edg2s/rangefix#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add selection span elements in order reedsy/quill-cursors
1 participant
@alecgibson