Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic when resize window in windows terminal #69

Open
M09Ic opened this issue Sep 9, 2024 · 2 comments
Open

panic when resize window in windows terminal #69

M09Ic opened this issue Sep 9, 2024 · 2 comments
Labels
bug Something isn't working display help wanted Extra attention is needed terminal windows All things related to Windows systems

Comments

@M09Ic
Copy link

M09Ic commented Sep 9, 2024

example code: https://github.com/reeflective/console/tree/main/example

env: windows 11, windows terminal

go run ./example

resize windows terminal

❯ go run .\example\

  _____            __ _           _   _              _____                      _
 |  __ \          / _| |         | | (_)            / ____|                    | |
 | |__) |___  ___| |_| | ___  ___| |_ ___   _____  | |     ___  _ __  ___  ___ | | ___
 |  _  // _ \/ _ \  _| |/ _ \/ __| __| \ \ / / _ \ | |    / _ \| '_ \/ __|/ _ \| |/ _ \
 | | \ \  __/  __/ | | |  __/ (__| |_| |\ V /  __/ | |___| (_) | | | \__ \ (_) | |  __/
 |_|  \_\___|\___|_| |_|\___|\___|\__|_| \_/ \___|  \_____\___/|_| |_|___/\___/|_|\___|

example [main] in console
> ffatal error: all goroutines are asleep - deadlock!                                                                                                                                                                                                   01:58:15.277

goroutine 1 [chan send (nil chan)]:
github.com/reeflective/readline/internal/core.(*Keys).readInputFiltered(0xc0000f4000)
        D:/SDK/go/gopath/pkg/mod/github.com/reeflective/readline@v1.0.15/internal/core/keys_windows.go:84 +0x34
github.com/reeflective/readline/internal/core.WaitAvailableKeys(0xc0000f4000, 0x83095a?)
        D:/SDK/go/gopath/pkg/mod/github.com/reeflective/readline@v1.0.15/internal/core/keys.go:70 +0x14f
github.com/reeflective/readline.(*Shell).Readline(0xc000037040)
        D:/SDK/go/gopath/pkg/mod/github.com/reeflective/readline@v1.0.15/readline.go:89 +0x24e
github.com/reeflective/console.(*Console).StartContext(0xc0001a4000, {0x8b6738, 0xb7ca60})
        D:/Programing/go/console/run.go:48 +0x1c6
github.com/reeflective/console.(*Console).Start(...)
        D:/Programing/go/console/run.go:19
main.main()
        D:/Programing/go/console/example/main.go:79 +0x189
exit status 2

@maxlandon maxlandon added windows All things related to Windows systems bug Something isn't working help wanted Extra attention is needed terminal display labels Nov 16, 2024
@maxlandon
Copy link
Member

Hello, sorry for not answering earlier.
Yes indeed this error is due to the fact I did not correctly comment out the code here:

func WatchResize(eng *Engine) chan<- bool {

This has been commented because I have to solve this Windows resize issue, which I have not had time to work on recently. I will soon enough, please be patient !
Thanks a lot

@M09Ic
Copy link
Author

M09Ic commented Nov 17, 2024

Thank you for your response. It seems I managed to resolve the issue myself. Indeed, as you mentioned, simply restoring the commented-out code did the trick.

I really appreciate your work. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working display help wanted Extra attention is needed terminal windows All things related to Windows systems
Projects
None yet
Development

No branches or pull requests

2 participants