-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] ThemedSiderV2 Persist Collapsed State #6508
Comments
@aress31 thanks for the issue. We've discussed this one and decided to accept Then Here, we should replace existing Here is a pseudo implementation: This will allow users to persist their collapsed state into localstorage in We need to do these changes in ThemedLayoutV2 component for
They all have almost exact same code, so it should be straightforward to implement. We are open to contributions for this one. |
Hey @BatuhanW, can I work on this? |
Hey @BatuhanW, I am up for this. |
@wannabecsguy2 Assigning issue to you since you were first to ask 🚀 @OmkarBansod02 If we don't hear back from @wannabecsguy2 you can take this next. We also have other issues that you may want to work on, you can check up for grabs labelled issues ❤️ |
hey @BatuhanW it's been a while. can you assign me this issue so i can make PR . |
hey @BatuhanW I'm getting a TypeScript error: Property |
@OmkarBansod02 assigned issue to you. It seems like it should work, you can restart TS server. |
@BatuhanW, Still getting same error even after restarting TS server. i am adding code snippets below kindly check am i on right path .
|
@OmkarBansod02 ui-types is a separate package. So you need to build it for other packages to see its types. You can run |
Thanks for help @BatuhanW , I have made a PR kindly review it and let me know for any improvement. |
Is your feature request related to a problem? Please describe.
Would be nice to persist out of the box the collapsed state, or add an option to do so, maybe a "peristCollapsed" boolean. This would avoid having to write extra code for this important UX feature.
Describe alternatives you've considered
No response
Additional context
No response
Describe the thing to improve
See above.
The text was updated successfully, but these errors were encountered: