Decouple Refinery CMS from ActsAsIndexed #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <%= hidden_field :callback, nil, :name => 'callback', :id => nil, :value => @callback if @callback.presence %> | ||
| <%= submit_tag t('button_text', :scope => 'refinery.admin.search'), :name => nil %> | ||
| </form> | ||
| <%= render :partial => 'refinery/acts_as_indexed/admin/search', |
There was a problem hiding this comment.
Could this instead be:
<%= render 'refinery/acts_as_indexed/admin/search', local_assigns if defined?(Refinery::ActsAsIndexed::Engine) %>
|
refinerycms/core/lib/refinery/crud.rb Line 204 in b9e40fb This line blows without AAI. It will be nice to replace it with search or similar method and delegate it to with_query with decorators in model. |
|
@simi alright if we do that as "step 2"? |
There is still some work to go with crudify. Changes: * Removed gemspec dependencies on acts_as_indexed * Clear out search partials so that refinerycms-acts-as-indexed can implement them. * Added Gemfile dependency on refinerycms-acts-as-indexed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.