Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show/Hide Screens #161

Closed
nwittwer opened this issue Jan 30, 2020 · 4 comments · Fixed by #166 or #169
Closed

Feature: Show/Hide Screens #161

nwittwer opened this issue Jan 30, 2020 · 4 comments · Fixed by #166 or #169

Comments

@nwittwer
Copy link
Collaborator

Ability to hide or show a screen on the canvas. Most likely makes sense in the right-click context menu for the sidebar and when clicking on a screen.

  1. Add menu item to context menu to Show or Hide screen (should change title based on its current state)
  2. Add Vuex Store property to artboards that defines their show/hide state
  3. Add Vuex Store methods to toggle the state of the hidden/shown artboard
@emilkowalski
Copy link
Contributor

Hi, can I take this one? :)

@nwittwer
Copy link
Collaborator Author

nwittwer commented Jan 31, 2020

@emilkowalski Sure! :) Let me know if you run into any issues getting it running or finding things. Try branching off from dev.

@emilkowalski
Copy link
Contributor

emilkowalski commented Feb 3, 2020

@nwittwer I have managed to implement this feature, but forgot to branch off from dev, that's why I closed the pull request. I've branched off from dev now, but when I run yarn run dev, im getting an error:
"Cannot read property 'length' of undefined"
It's about artboards.length.
Had no issues working from master.
Any idea how I can fix it so that I can implement my solution? :

@nwittwer
Copy link
Collaborator Author

nwittwer commented Feb 3, 2020

@emilkowalski Sorry about the late comment about branching from dev, I'll try and update the readme to make that more straightforward.

To fix that other issue you mentioned, try clearing your local storage by opening the DevTools > Application > Local Storage > file:// > and then delete the Reflex key. After reloading the app it should work again. I'd like to add an OS menu item to easily delete this, because I think this error happens when the localStorage data model has changed. It is a migration issue. Please let me know if it isn't fixed after that. UPDATE: I've detailed this bug and an idea to deal with it here: #165

I haven't been able to try it out yet, but I think your solution seems good! Please go ahead and try the fix and then make another PR :)

@nwittwer nwittwer linked a pull request Feb 4, 2020 that will close this issue
@nwittwer nwittwer linked a pull request Feb 23, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants