Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF-2027] rx.color should accept "accent" as a valid color #2674

Closed
masenf opened this issue Feb 20, 2024 · 7 comments · Fixed by #2713
Closed

[REF-2027] rx.color should accept "accent" as a valid color #2674

masenf opened this issue Feb 20, 2024 · 7 comments · Fixed by #2713
Assignees

Comments

@masenf
Copy link
Collaborator

masenf commented Feb 20, 2024

Describe the bug
No easy way to reference a shade of the primary theme accent_color without resorting to CSS var str literal like var(--accent-10)

To Reproduce

import reflex as rx

rx.color("accent", 10)
ValueError: prop value for color of the `color` component should be one of the following: 'gray','mauve','slate','sage','olive','sand','tomato','red','ruby','crimson','pink','plum','purple','violet','iris','indigo','blue','cyan','teal','jade','green','grass','brown','orange','sky','mint','lime','yellow','amber','gold','bronze'. Got 'accent' instead

REF-2027

@masenf masenf changed the title rx.color should accept "accept" as a valid color [REF-2027] rx.color should accept "accept" as a valid color Feb 20, 2024
@wassafshahzad
Copy link
Contributor

Please assign it to me

@masenf
Copy link
Collaborator Author

masenf commented Feb 20, 2024

picked up by OSS contributor wassafshahzad

@wassafshahzad
Copy link
Contributor

OSS

In the title did you mean accent ?

@masenf masenf changed the title [REF-2027] rx.color should accept "accept" as a valid color [REF-2027] rx.color should accept "accent" as a valid color Feb 20, 2024
@masenf
Copy link
Collaborator Author

masenf commented Feb 20, 2024

In the title did you mean accent ?

yes 100% 😊. The generic name for the theme accent_color is accent.

@Yummy-Yums
Copy link
Contributor

hey guys sorry i thought this was dormant or something, dropped the PR. The assignee can go ahead

@wassafshahzad
Copy link
Contributor

@Yummy-Yums You can take the issue since your already have a PR up. I can take another issue

@Yummy-Yums
Copy link
Contributor

Yummy-Yums commented Feb 22, 2024

@Yummy-Yums You can take the issue since your already have a PR up. I can take another issue

oh no, it's not cool..I'm already working on another issue as well..unexpected behaviour of a button so I'm investigating which will take some time.

reflex-dev/reflex-web#497

@masenf masenf added this to the v.23 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants