Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF-3016] Upload ID should allow characters #3444

Closed
abulvenz opened this issue Jun 5, 2024 · 1 comment · Fixed by #3449
Closed

[REF-3016] Upload ID should allow characters #3444

abulvenz opened this issue Jun 5, 2024 · 1 comment · Fixed by #3449
Labels
linear Created by Linear-GitHub Sync Reflex > Open source core OSS Created by Linear-GitHub Sync
Milestone

Comments

@abulvenz
Copy link
Contributor

abulvenz commented Jun 5, 2024

Describe the bug
Using an ID like this on_click=State.handle_upload(rx.upload_files(upload_id="cv-upload")),
Will cause a rendering like this:

{files:filesById.cv-upload,upload_id:`cv-upload`}

Expected behavior
Should be rendered as

{files:filesById[`cv-upload`],...

And not cause the error upload is not defined.

Can also be solved by throwing an error and editing the docs, but that would not be the preferred solution.

REF-3016

@abulvenz abulvenz added the bug Something isn't working label Jun 5, 2024
@ElijahAhianyo ElijahAhianyo added the linear Created by Linear-GitHub Sync label Jun 5, 2024
@masenf masenf added linear Created by Linear-GitHub Sync and removed linear Created by Linear-GitHub Sync labels Jun 5, 2024
@masenf masenf changed the title Upload ID must not contain - or other "special" characters [REF-3016] Upload ID must not contain - or other "special" characters Jun 5, 2024
@masenf masenf modified the milestones: Open Source Bugs, v.37 Jun 5, 2024
@masenf masenf changed the title [REF-3016] Upload ID must not contain - or other "special" characters [REF-3016] Upload ID should allow characters Jun 6, 2024
@masenf masenf modified the milestones: v.37, v.38 Jun 9, 2024
@abulvenz
Copy link
Contributor Author

Thanks for the fix!

@masenf masenf added Reflex > Open source core OSS Created by Linear-GitHub Sync bug Something isn't working and removed bug Something isn't working labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear Created by Linear-GitHub Sync Reflex > Open source core OSS Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants