Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy matrix doesn't support excluding some combinations #40

Open
erwan opened this issue May 11, 2021 · 2 comments
Open

Strategy matrix doesn't support excluding some combinations #40

erwan opened this issue May 11, 2021 · 2 comments

Comments

@erwan
Copy link

erwan commented May 11, 2021

Currently, Strategy::matrix is defined as a List { mapKey : Text, mapValue : List Text }:

https://github.com/regadas/github-actions-dhall/blob/master/types/Strategy.dhall

However, Github Actions supports having an exclude key that is a list of records (not Text):

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-excluding-configurations-from-a-matrix

Currently it's not possible to specify an exclude field in the matrix, because it doesn't match the type.

@regadas
Copy link
Owner

regadas commented Jun 26, 2021

Hi @erwan! Thanks for the report!

Do you feel you can find some time to propose a fix? 😄 🙏

@erwan
Copy link
Author

erwan commented Jun 26, 2021

Actually I tried, but I don't know how to fix it! I couldn't find a way to type the exclude field.

It's too generic, we would want a list of objects that can have any key. I couldn't find how to do that in dhall...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants