Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORM Tables can't handle key which is prefix of another #456

Closed
4 tasks
ruhatch opened this issue Aug 4, 2021 · 2 comments · Fixed by #459
Closed
4 tasks

ORM Tables can't handle key which is prefix of another #456

ruhatch opened this issue Aug 4, 2021 · 2 comments · Fixed by #459
Labels
Scope: orm Issues that update the orm module Type: Bug Something isn't working
Milestone
v2.0 - Baikal Upg...

Comments

@ruhatch
Copy link
Contributor

ruhatch commented Aug 4, 2021

Summary of Bug

PrimaryKeyTables in the orm package cannot have keys where one is a prefix of another. For example, if there is already a key AA in the table, then the table will claim to already have the key A in the table. Calling Create on an object with primary key A would then fail, because it would violate the unique constraint.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ruhatch ruhatch added Type: Bug Something isn't working Scope: orm Issues that update the orm module labels Aug 4, 2021
@ruhatch ruhatch added this to the v2.0 - Baikal Upgrade milestone Aug 4, 2021
@ruhatch ruhatch mentioned this issue Aug 4, 2021
Closed
4 tasks
@blushi blushi mentioned this issue Aug 11, 2021
Closed
4 tasks
@clevinson
Copy link
Member

@blushi Was the latest from your conversations with Ru that this needs to be addressed as part of v2.0?

This was referenced Aug 13, 2021
Merged
Closed
@blushi
Copy link
Member

blushi commented Aug 13, 2021 •
edited
Loading

@blushi Was the latest from your conversations with Ru that this needs to be addressed as part of v2.0?

yeah just opened up a PR for that #459

@ruhatch ruhatch mentioned this issue Sep 8, 2021
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Scope: orm Issues that update the orm module Type: Bug Something isn't working
Projects
None yet
Milestone
v2.0 - Baikal Upgrade
Development

Successfully merging a pull request may close this issue.

fix: Fix primary keys format and add property tests to the ORM package regen-network/regen-ledger
3 participants
@clevinson @blushi @ruhatch