Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecocredit refactor follow-ups #728

Closed
3 of 8 tasks
Tracked by #818
technicallyty opened this issue Feb 8, 2022 · 2 comments · Fixed by #995
Closed
3 of 8 tasks
Tracked by #818

ecocredit refactor follow-ups #728

technicallyty opened this issue Feb 8, 2022 · 2 comments · Fixed by #995
Assignees
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature

Comments

@technicallyty
Copy link
Contributor

technicallyty commented Feb 8, 2022

Summary

after #696 we will need to:


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ryanchristo ryanchristo added the Scope: x/ecocredit Issues that update the x/ecocredit module label Mar 4, 2022
@ryanchristo ryanchristo added this to the v4.0 - Llangorse Upgrade milestone Mar 6, 2022
@ryanchristo ryanchristo added Status: Blocked Scope: x/ecocredit Issues that update the x/ecocredit module and removed Scope: x/ecocredit Issues that update the x/ecocredit module Status: Blocked labels Mar 8, 2022
@ryanchristo
Copy link
Member

ryanchristo commented Mar 27, 2022

We have separate tracking issues for "refactor simulations" (#920 and #921) so I removed it from here. We should be able to "refactor operations" and "use index delete in expired orders pruning" at this point.

I'm not sure I understand what needs to be done for "refactor tests" - is this related to rewriting acceptance tests using gherkin syntax and then implementing those tests using gocuke? If so, we have separate issues tracking the initial rewriting that needs to be done (#893, #894, #895, #896) and we can open up followup issues for implementing once we have the acceptance tests rewritten.

We should also prioritize migrations and features so that we are ready for a v4.0 upgrade if we need added support for bridging polygon assets sooner than later. We could also do some of the acceptance test work during the audit/testing phase. I think it would be safe to remove "refactor tests" from the list here unless you had something else in mind.

@technicallyty
Copy link
Contributor Author

I'm not sure I understand what needs to be done for "refactor tests"

yeah this was a pretty early issue in the re-design/re-factoring, i believe my thoughts at the time were around unit testing. but with that mostly done on a per-PR basis, i think the biggest refactoring of tests would be cleaning up our current integration tests. i imagine things will be broken once the submodules are wired up to the main module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants