You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When passport.js 0.6.x is installed in the registry-server we get this error:
TypeError: req.session.regenerate is not a function
at SessionManager.logIn (/Users/kyle/regen/registry-server/node_modules/passport/lib/sessionmanager.js:28:15)
at IncomingMessage.req.login.req.logIn (/Users/kyle/regen/registry-server/node_modules/passport/lib/http/request.js:39:26)
at Strategy.strategy.success (/Users/kyle/regen/registry-server/node_modules/passport/lib/middleware/authenticate.js:256:13)
at verified (/Users/kyle/regen/registry-server/node_modules/passport-custom/lib/strategy.js:56:8)
at Strategy._verify (/Users/kyle/regen/registry-server/server/middleware/passport.ts:79:20)
at Strategy.authenticate (/Users/kyle/regen/registry-server/node_modules/passport-custom/lib/strategy.js:60:8)
at attempt (/Users/kyle/regen/registry-server/node_modules/passport/lib/middleware/authenticate.js:369:16)
at authenticate (/Users/kyle/regen/registry-server/node_modules/passport/lib/middleware/authenticate.js:370:7)
at Layer.handle [as handle_request] (/Users/kyle/regen/registry-server/node_modules/express/lib/router/layer.js:95:5)
at trim_prefix (/Users/kyle/regen/registry-server/node_modules/express/lib/router/index.js:323:13)
Newer versions of passport.js require this req.session.regenerate API.
express/cookie-session does not make use of this API and they do not plan to fix it (ref).
A workaround was shared here: jaredhanson/passport#904 (comment)
We can try this workaround to perform the upgrade.
Alternative ideas:
@blushi i think we should pull this into the next sprint if possible.
i don't want to fall to far behind with passport.js since it's an important dependency.
this will involve some hacking for finding the best support path, and thorough testing.
Describe the bug
When passport.js 0.6.x is installed in the registry-server we get this error:
Related upstream issues: jaredhanson/passport#907, jaredhanson/passport#904
In order to upgrade passport to > 0.5.x, we will need to have a fix for the issue above.
Found during work in PR: https://github.com/regen-network/registry-server/pull/227
For Admin Use
The text was updated successfully, but these errors were encountered: