Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showLineNumber dosent work when placed at the end of the meta tags. #204

Open
beamcode opened this issue Apr 24, 2024 · 1 comment · May be fixed by #229
Open

showLineNumber dosent work when placed at the end of the meta tags. #204

beamcode opened this issue Apr 24, 2024 · 1 comment · May be fixed by #229
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@beamcode
Copy link
Contributor

beamcode commented Apr 24, 2024

Is this expected ? Thanks!

- Works

```tsx showLineNumbers /age/#v /name/#v /setAge/#s /setName/#s /50/#i /"Taylor"/#i
const [age, setAge] = useState(50)
const [name, setName] = useState("Taylor")
```

- Does now work

```tsx /age/#v /name/#v /setAge/#s /setName/#s /50/#i /"Taylor"/#i showLineNumbers
const [age, setAge] = useState(50)
const [name, setName] = useState("Taylor")
```

@o-az o-az added bug Something isn't working good first issue Good for newcomers labels May 14, 2024
@o-az o-az linked a pull request Jul 4, 2024 that will close this issue
@o-az
Copy link
Member

o-az commented Jul 4, 2024

I've got a fix for this in #229

here's an example of it working when at end of metatags: https://d68419f3.rehype-pretty-example-astro.pages.dev/

```elixir title="fib.ex" /palindrome/#v showLineNumbers

just need to update tests in #229 then will merge and do a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants