Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't silently ignore tokens from themes without a name #244

Open
danbulant opened this issue Sep 5, 2024 · 0 comments
Open

Don't silently ignore tokens from themes without a name #244

danbulant opened this issue Sep 5, 2024 · 0 comments

Comments

@danbulant
Copy link

If we pass in a JSON theme and want to highlight tokens inline (the thing{:.tok} syntax), this requires a name even if just one theme is passed in. There's no warning or error about name not being present, and everything else works just fine.

Relevant code: https://github.com/rehype-pretty/rehype-pretty-code/blob/master/packages/core/src/index.ts#L309-L320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant