Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An unexpected highlighted word that matches in filename in v0.6.0 #52

Closed
dimaMachina opened this issue Dec 25, 2022 · 2 comments
Closed

An unexpected highlighted word that matches in filename in v0.6.0 #52

dimaMachina opened this issue Dec 25, 2022 · 2 comments

Comments

@dimaMachina
Copy link
Contributor

dimaMachina commented Dec 25, 2022 •
edited
Loading 

```js filename="a/hello/file.js"
console.log("hello")
```

image

image

originally reported in shuding/nextra#1088
@atomiks
Copy link
Collaborator

atomiks commented Dec 25, 2022

What is filename from? The check internally uses title to filter it out so maybe that's why:

https://github.com/atomiks/rehype-pretty-code/blob/8d6f00dcb2bd5abf17549879eef2f5748b69587b/src/index.js#L170-L173

@dimaMachina
Copy link
Contributor Author

filename is our custom metadata prop that will be rendered as header for code block

@dimaMachina dimaMachina mentioned this issue Dec 26, 2022
Closed
@atomiks atomiks closed this as completed Jan 8, 2023
@tlawrie tlawrie mentioned this issue May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix unexpected highlight words for custom meta properties dimaMachina/rehype-pretty-code
2 participants
@dimaMachina @atomiks