Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide tree-shakable exports? #77

Open
mikestopcontinues opened this issue Mar 31, 2021 · 5 comments
Open

Provide tree-shakable exports? #77

mikestopcontinues opened this issue Mar 31, 2021 · 5 comments

Comments

@mikestopcontinues
Copy link

Hi, I'd like to be able to import just the colors my site uses, but the package structure doesn't allow importing tree-shakable colors. (And it's a really big bundle!) It would be great to be able to do:

import {facebook, twitter} from 'brand-colors';

For a while, I was able to import the colors I needed directly from the json data, but after upgrading to webpack 5, it seems that options no longer available.

@morteza-jamali
Copy link

Hi, I'd like to be able to import just the colors my site uses, but the package structure doesn't allow importing tree-shakable colors. (And it's a really big bundle!) It would be great to be able to do:

import {facebook, twitter} from 'brand-colors';

For a while, I was able to import the colors I needed directly from the json data, but after upgrading to webpack 5, it seems that options no longer available.

I forked this repository and created my own customized version for javascript supporting . take a look .

@mikestopcontinues
Copy link
Author

@morteza-jamali Thanks! Awesome, man! :)
@reimertz I do still think this feature would be an excellent add to the source repo.

@reimertz
Copy link
Owner

reimertz commented Apr 6, 2021

Hi all! I am all up for adding this feature @mikestopcontinues!
@morteza-jamali, you up for creating a PR?

Also, I usually don't care about these things but I saw you(@morteza-jamali) deleted the LICENSE in your fork and replaced it with your own (name). I spent quite a lot of time to get this working back in the day so that made me a little bit sad. 😞

@morteza-jamali
Copy link

morteza-jamali commented Apr 6, 2021

Hi all! I am all up for adding this feature @mikestopcontinues!
@morteza-jamali, you up for creating a PR?

Also, I usually don't care about these things but I saw you(@morteza-jamali) deleted the LICENSE in your fork and replaced it with your own (name). I spent quite a lot of time to get this working back in the day so that made me a little bit sad. 😞

@reimertz thank you for your mentioning about license file . I removed license file accidently and re-generated it . I review source code and fix problems . Sorry about that 🙏
I'll create a PR soon .

@morteza-jamali
Copy link

@reimertz I created PR for this feature #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants