Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generic datatype for node ID #165

Open
vidarandrebo opened this issue Jan 25, 2024 · 1 comment
Open

feat: generic datatype for node ID #165

vidarandrebo opened this issue Jan 25, 2024 · 1 comment

Comments

@vidarandrebo
Copy link
Collaborator

The node id is now a unint32, but this does not always match up with the applications utilizing gorums. If an application does not use a uint32, it would either have to resolve a node from the config using ip address, or store and exchange gorums ids at the application level.

@meling
Copy link
Member

meling commented Jan 25, 2024

I think it makes sense to implement a generic node ID or a mapping from IP to a generic node ID, to avoid having separate Gorums IDs and application-level IDs. However, it would be nice to do a deeper analysis of Gorums' codebase to examine if this could cause problems in some way. @hanish520 @johningve @leandernikolaus Do you foresee any issues with this? (I haven't had time to dig into it myself yet.)

@vidarandrebo vidarandrebo changed the title Generic datatype for node ID feat: generic datatype for node ID Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants