Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why com.thaiopensource.relaxng.pattern.ElementPattern is not public? #271

Open
angelozerr opened this issue Oct 6, 2022 · 2 comments
Open

Comments

@angelozerr
Copy link

angelozerr commented Oct 6, 2022

I'm implementing a custom pattern function which implements PatternFunction to visit pattern (element, attributes, etc pattern) to support XML completion based on RelaxNG similar to
https://github.com/relaxng/jing-trang/blob/master/mod/pattern/src/main/com/thaiopensource/relaxng/pattern/DefaultValuesExtractor.java but I need to create my class in the com.thaiopensource.relaxng.pattern package because all classes which extends Pattern are not public

I wonder why there is this restriction? Is it possible to add a public modifier for ElementPattern and other classes?

@ndw
Copy link
Contributor

ndw commented Oct 6, 2022

I'm not aware of any compelling reason for them not to be public.

@angelozerr
Copy link
Author

Thanks @ndw for your answer. I will create a PR to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants