Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parcels with a backing service as a destination aren't filtered out #103

Open
gnarea opened this issue Jul 11, 2020 · 0 comments
Open

Parcels with a backing service as a destination aren't filtered out #103

gnarea opened this issue Jul 11, 2020 · 0 comments
Labels
bug Something isn't working PDC Parcel Delivery Connection

Comments

@gnarea
Copy link
Member

gnarea commented Jul 11, 2020

Someone could craft a parcel in such a way that it'd result in a POST request from a background queue. It's unlikely that such requests will work, being as the payload would be a parcel, but to guard against the unlikely case that one of those requests could have undesired effects, we should refuse destinations whose host name matches one of the following:

  • Its TLS is .local
  • It's got no TLD (e.g., vault).
  • It's a private subnet IP address.
@gnarea gnarea added bug Something isn't working PDC Parcel Delivery Connection labels Jul 11, 2020
@gnarea gnarea added this to the Production release milestone Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PDC Parcel Delivery Connection
Projects
None yet
Development

No branches or pull requests

1 participant