Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyConfigParser should not raise KeyError when assigning value #14

Open
lubomir opened this issue May 5, 2016 · 0 comments
Open

PyConfigParser should not raise KeyError when assigning value #14

lubomir opened this issue May 5, 2016 · 0 comments

Comments

@lubomir
Copy link
Contributor

lubomir commented May 5, 2016

Currently if you try to set key starting with underscore, KeyError is raised.
https://github.com/release-engineering/kobo/blob/master/kobo/conf.py#L92-L95

This is confusing for users encountering this exception, as the documentation says:

Raised when a mapping (dictionary) key is not found in the set of existing keys.

I assume there is some reasoning why these keys are rejected, but I suggest using different exception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lubomir