-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to support release-it@15 (ESM) #73
Refactor to support release-it@15 (ESM) #73
Conversation
4aabff0
to
0cf96f4
Compare
I tried copying the files in this pull request into my monorepo and I can confirm that it works for me. Successfully published. |
It looks like nothing has been committed to this repo since Oct 2021, the latest release in Apr that year. The author is not active. I think we should consider a fork. Are you interested in collaborating on one? @refi93 |
I see, I'm not sure if I would have the time for maintaining the fork long-term either, but of course, whoever can, feel free to pick these changes up and make it 👍 |
@rwjblue has been out on holiday. I'm happy to take a look at this too. We don't need a fork. I just finished a large ESM refactor myself, so hopefully can provide assistance. |
Since we're going to be releasing this as a breaking change, and the ESM conversion essentially opts us into ESM-land, it strikes me that we should remove |
It looks like we'll need to remove the required checks, but I don't have access to this repo's settings since it's under @rwjblue's personal GH user. I'll try to ping him to address this once he's back. |
Motivation: refactor the package to work with
release-it
v15 which transitioned to ESM modulesTesting: run unit tests with
yarn test
closes #68