Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder.jpg not working for cover art #256

Closed
Hk1020 opened this issue Nov 25, 2017 · 5 comments
Closed

Folder.jpg not working for cover art #256

Hk1020 opened this issue Nov 25, 2017 · 5 comments

Comments

@Hk1020
Copy link

Hk1020 commented Nov 25, 2017

Expected behavior

Albums should show cover art contained in file Folder.jpg as per the documentation

Actual behavior

No cover art is shown

Steps to reproduce the behavior

  1. Have a folder with mp3 files which don't include cover art and a file Folder.jpg
  2. scan for music
  3. show albums

Possible solution (optional)

Additional information (optional)

If Folder.jpg is renamed to folder.jpg the cover art is shown after reset library/scan for audio files. The same behavior exists for cover.jpg

Server configuration

Operating system:
linux

Web server:
apache

Database:
mysql

PHP version:

Nextcloud/ownCloud version: (see /status.php)
12.0.3

Updated from an older Nextcloud/ownCloud or fresh install:

Audio Player version: (see /settings/apps)
2.2.1

Where did you install Audio Player from:

Are you using external storage, if yes which one: local/smb/sftp/...

Are you using encryption: yes/no

Client configuration

Operating system:

Browser:

Logs

Nextcloud/ownCloud log

Nextcloud/ownCloud log (`/data/[nextcloud|owncloud].log`)
Insert your Nextcloud/ownCloud log here

Web server error log (optional)

Web server error log
Insert your web server log here

Browser log (optional)

Browser log
Insert your browser log here
@Hk1020 Hk1020 changed the title folder.jpg not working for cover art Folder.jpg not working for cover art Nov 26, 2017
@ghost ghost assigned Rello Nov 26, 2017
@ghost ghost added this to the 2.2.2 milestone Nov 26, 2017
@ghost ghost added bug scanner labels Nov 26, 2017
@ghost
Copy link

ghost commented Nov 26, 2017

@Hk1020 In the documentation is nothing of file names with capital letters. It works as described!

@ghost ghost added the metadata label Nov 26, 2017
@Hk1020
Copy link
Author

Hk1020 commented Nov 26, 2017

@xraMsamohT You are right, I didn't read it carefully enough. But Windows Media Player writes Folder.jpg in every directory, so no artwork shown.

@Hk1020
Copy link
Author

Hk1020 commented Dec 13, 2017

I just checked the latest commits. Why don't you simply make all file names case insensitive? Any reason to distinguish Folder.jpg and folder.jpg? If you deploy on Windows it'll work that way anyway.

@Rello
Copy link
Owner

Rello commented Dec 13, 2017

hello,
we are dependent in NC standard classes to not scan the filecache table (or even the files locally) every time. and this class is case dependent to derive a unique file path for every file.
because one folder can have a Folder.jpg and a folder.jpg and they might have a different meaning

ghost pushed a commit that referenced this issue Dec 14, 2017
@Rello
Copy link
Owner

Rello commented Dec 26, 2017

Released with 2.2.2

@Rello Rello closed this as completed Dec 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants