Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember playback volume #517

Closed
jojosoft opened this issue Jan 6, 2021 · 2 comments
Closed

Remember playback volume #517

jojosoft opened this issue Jan 6, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@jojosoft
Copy link

jojosoft commented Jan 6, 2021

Big thanks to @Rello for actively developing my favorite Nextcloud app! I was happy to dump iTunes and its weird (artificial) restrictions – it's like hosting your own free and privacy-respecting Spotify. However, over the last year, I noticed some things that got a little worse than before (mainly related UI), so I decided to open several smaller issues to address them.

Actual behavior

The volume slider starts at 1 by default (after reloading the site) and is configured to allow steps of 0.1 units. It's just a small detail, but it would probably increase most user's experience to have it start at 0.5 (or even remember the last value!) and also allow for steps of maybe 0.05. Most of modern music has been strongly compressed with regards to dynamics, so for those songs, users will usually only have a choice between 0.1, 0.2, 0.3 and 0.4 if they don't want to reduce the system volume for all applications in their operating system. (And want to keep their hearing. 😉)

Steps to reproduce the behavior

  1. Open Audio Player, start playback of any song and adjust the volume
  2. Wait a bit to make extra sure that no "delayed" AJAX request is lost
  3. Close the tab in which Audio Player was loaded
  4. Open Audio Player and see how the volume is back at 1 again

Server configuration

Operating system:
Debian 10

Web server:
Apache

Database:
mysql

Nextcloud/ownCloud version: (see /status.php)
19.0.6

Audio Player version: (see /settings/apps)
2.13.1

Are you using external storage? If yes, which one: local/smb/sftp/...
No.

Client configuration

Browser:
Firefox 84.0

@Rello
Copy link
Owner

Rello commented Jan 6, 2021

the volume is actually saved and reused during restart.
can you double check if it is really not working? I can check later on my side

@Rello Rello added needs info feedback from requester required playlist labels Jan 6, 2021
@jojosoft
Copy link
Author

jojosoft commented Jan 6, 2021

Thank you! I have adjusted my description to contain the steps I follow to reproduce the behavior.

@Rello Rello changed the title Steps and default value of the volume slider Remember playback volume Feb 16, 2021
@Rello Rello added this to the 3.0.1 milestone Feb 16, 2021
Rello added a commit that referenced this issue Feb 16, 2021
@Rello Rello self-assigned this Feb 16, 2021
@Rello Rello added pending release and removed needs info feedback from requester required labels Feb 16, 2021
@Rello Rello closed this as completed Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants