suggest: support table

[sinkcup]

suggest: support GFM(GitHub flavored markdown) tables: https://help.github.com/articles/organizing-information-with-tables/

| Command | Description |
| --- | --- |
| `git status` | List all *new or modified* files |
| `git diff` | Show file differences that **haven't been** staged |

[ztratar]

These are pretty important. Would love to see!

[rexxars]

I'd love to support them, but commonmark does not include them in the spec. I'm going to start experimenting with an alternative markdown parser. It might take a while to complete, since it'll almost be a complete rewrite, however.

[aviadl]

+1
Can you please share the status on this ?

[rexxars]

Have no gotten much farther on this. Have experimented with alternative markdown parsers, and know that it's doable, it's just a matter of getting time to do it. Right now other projects are taking up most of my time. Don't want to give out estimates for open-source work as it totally depends on how much free time I have to work on it, which varies.

[TakanashiOuken]

+1 For this
Really need the table working

[sauravskumar]

+1 for table... really need it... please please add it

[sauravskumar]

https://github.com/chjj/marked this markdown parser has support for tables...

[Swivelgames]

This was pretty damn awesome until I almost finished what I was working on, tried to use a table, and it fell flat on its face 😢

Switched over to remarkable and highlight.js as seen in Facebook's own Markdown React example.

[sasha240100]

+1 For tables

[tuchk4]

tuchk4/storybook-readme#4

[rexxars]

Just thought I'd let you guys know that I've started working on the next major release of react-markdown, which will switch from commonmark to markdown, thus enabling tables (among other things).

There will be some breaking changes to the API, but nothing that should take too long to fix.

[alecmev]

@rexxars

Nice to hear, but which library in particular do you intend to use, and why abandon CommonMark? Why not markdown-it, another CM-compatible library, acknowledged by jgm, the main guy behind CM?

In my use case, if you were to use something non-CM, the difference would probably be minimal, since the only user-generated content we have is comments, which people rarely format, and the rest can be adjusted relatively easily. But what about those with gigabytes of Markdown data, which might render differently?

[rexxars]

@jeremejevs I'll continue to maintain commonmark-react-renderer, which to be fair is pretty much where all the logic of react-markdown resides. In hindsight, I should have named this module react-commonmark, since that's what it currently renders. Perhaps now would be a good time to fork and publish just that.

[alecmev]

@rexxars I understand that the current implementation can and will be maintained, and that nobody is forced to switch, but it would be nice to have both CM-compatibility and tables. That lets existing users upgrade easily, and, on the religious front, we can remain invested into a proper standard.

[rexxars]

@jeremejevs As in; being able to opt-out of non-commonmark types?

Are there any compatibility issues in particular you're worried about? For most people, I'd think that the move would result in little or no changes in the rendered output.

[alecmev]

@rexxars As in rendering everything the same way commonmark.js would. There are no issues in particular I'm worried about, I just know for sure that most renderers differ in one way or another. Take a look at Babelmark's examples of divergences (look for markdown-it as a representative of CommonMark).

[tbillington]

Just curious about the status of the implementation of tables, are any rough goals ?

[martellaj]

Anyone with a simple use-case and just needs table support, I found react-remarkable to be a light-weight solution that's easily swappable with react-markdown.

[rexxars]

@tbillington Been caught up with real-life lately, but I'm going to work on react-markdown this weekend, hoping to get closer.

[tbillington]

@rexxars Which table format would you implement, github style?

[rexxars]

Yup, Github-style.

[agustinlg]

+1 for tables! thanks!

[sichvoge]

@rexxars do you have an update on this?

[rexxars]

Been in the hospital for the past week, and I am in no fit state to code right now. It's pretty close, but not willing to give estimates based on health

[FlorianWendelborn]

@rexxars Good luck with that! Don't worry about this issue and take your time. Nobody is forcing you. 😄

[sichvoge]

Agree to @dodekeract. Health should always be first priority! Thanks for all your good work.

[simonbuerger]

@rexxars Sorry to hear. Thanks for all your hard work on this.

And I'm with them ^ take care of yourself first!

[pnepe6]

Like everyone, I hope everything going well. You do a great job and your module rocks! Looking forward to see tables implementation. Take care of yourself.

[simen]

Awesome stuff! Really need github-style table support to display some release notes in an app I'm working on. Looking forward to it!

[rexxars]

The new release candidate for v3 has table support. Please read this issue for more information. Please give it a go and let me know if you encounter issues.

[rexxars]

Closing this issue to make it easier for me to keep track of pending issues.

[rwlaschin]

This is great, I really need tables as well.

The other thing I noticed is that
doesn't render as expected.