Issue with typings with later versions of hast

[benjdlambert]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions

react-markdown

Link to runnable example

No response

Steps to reproduce

Install react-markdown and run typescript with --skipLibCheck=false

Expected behavior

Types are happy and the library has 0 typescript errors

Actual behavior

node_modules/react-markdown/lib/rehype-filter.d.ts:2:43 - error TS2344: Type 'Root' does not satisfy the constraint 'void | Node<Data>'.
  Type 'Root' is not assignable to type 'Node<Data>'.
    Types of property 'data' are incompatible.
      Type 'import("/tmp/backstage-e2e-Ukrwaf/test-app/node_modules/@types/hast/node_modules/@types/unist/index").Data | undefined' is not assignable to type 'import("/tmp/backstage-e2e-Ukrwaf/test-app/node_modules/@types/unist/index").Data | undefined'.
        Type 'import("/tmp/backstage-e2e-Ukrwaf/test-app/node_modules/@types/hast/node_modules/@types/unist/index").Data' is not assignable to type 'import("/tmp/backstage-e2e-Ukrwaf/test-app/node_modules/@types/unist/index").Data'.
          Index signature for type 'string' is missing in type 'Data'.

2   this: import('unified').Processor<void, import('hast').Root, void, void>,
                                            ~~~~~~~~~~~~~~~~~~~

node_modules/react-markdown/lib/rehype-filter.d.ts:6:35 - error TS2344: Type 'Root' does not satisfy the constraint 'Node<Data>'.

6   | import('unified').Transformer<import('hast').Root, import('hast').Root>
                                    ~~~~~~~~~~~~~~~~~~~

Looks like there's some type incompatibility with later packages that have been released. This is blocking our pipeline and E2e tests for Backstage. We've had a suggestion that a potential fix is to bring in @types/unist@<3.0.0, maybe that needs implementing here or should we open an issue over there?

backstage/backstage#18643

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response

[remcohaszing]

This is an upstream issue that’s being worked on. See DefinitelyTyped/DefinitelyTyped#65789 (comment) for details and a workaround.

[wooorm]

External as Remco mentions, see DefinitelyTyped/DefinitelyTyped#66029.