-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow selection between warning, error and ignoring regarding the validity of links #77
Comments
Continuing this conversation on from https://github.com/orgs/remarkjs/discussions/1217#discussioncomment-6796453: What do you mean, “jarring”? Why do you think broken URLs are errors? What else are you using? Are you only using
ESLint is just a linter. From here:
Can you expand on this scenario? What do you mean?
You mean the package Errors vs warnings in unified mean something. I don’t think you want the actual behavior that that difference results in. |
What if I used another Remark plugin and it raises a warning? If I use |
If you use plugins that raise regular messages, plugins run.
|
So the solution is to run Remark for link validation with |
You never explained what your problem is, you proposed a solution. I think the solution for your problem is to use |
What you mention just now as a solution would be a solution to what you are proposing here though. To turn warnings for links into errors. Then you’d need to run twice. |
I guess yes. I thought Remark errors were like linter errors. |
Closing as I don’t yet think there is a good reason to add such code, |
Initial checklist
Problem
It's kinda jarring and odd to use
--frail
to catch warnings as errors and exit with 1. Also, other Remark warnings could cause errors if they are raised at lint time.Solution
We should be able to specify the severity to be reported as "error", "warn" or "ignore".
Example:
Alternatives
Another way would be to directly modify Remark itself, but I think this is much better.
The text was updated successfully, but these errors were encountered: