Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CommonMark] Issue with BEM-style CSS class name #337

Closed
danburzo opened this issue Jun 13, 2018 · 2 comments
Closed

[CommonMark] Issue with BEM-style CSS class name #337

danburzo opened this issue Jun 13, 2018 · 2 comments
Labels
👯 no/duplicate Déjà vu

Comments

@danburzo
Copy link

Subject of the issue

Remark 9.0.0 parses this incorrectly: __`uix-list__item`__

Expected behaviour

It should parse it as: uix-list__item

Actual behaviour

AST Explorer
@ChristianMurphy
Copy link
Member

Thanks @danburzo!
This matches up with the expectation from https://spec.commonmark.org/0.28/#example-367
PRs are welcome!

@ChristianMurphy ChristianMurphy added 🐛 type/bug This is a problem remark-parse needs pr 👶 semver/patch This is a backwards-compatible fix labels Jul 24, 2018
@wooorm
Copy link
Member

wooorm commented Aug 19, 2018

Duplicate of GH-75. But yeah, PRs definitely welcome!

@wooorm wooorm closed this as completed Aug 19, 2018
@wooorm wooorm added 👯 no/duplicate Déjà vu and removed 🐛 type/bug This is a problem needs pr 👶 semver/patch This is a backwards-compatible fix remark-parse labels Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👯 no/duplicate Déjà vu
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danburzo @wooorm @ChristianMurphy