Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose history.entries on memory history #828

Open
fdecampredon opened this issue Aug 17, 2020 · 9 comments
Open

Expose history.entries on memory history #828

fdecampredon opened this issue Aug 17, 2020 · 9 comments

Comments

@fdecampredon
Copy link

While history.entries is not possible on browser or hash history It would be still very useful to expose it on memory history especially for mobile applications where stacks render not only the current route but all the previous one.

@Nantris
Copy link

Nantris commented Sep 20, 2021

Is this feature dead in history@5.x? That would be a damn shame that locks us on history@4.x forever.

@Nantris
Copy link

Nantris commented Sep 20, 2021

It seems like it would be trivial to expose. Is there some rationale for no longer exposing entries?

I'm guessing/hoping it's just to standardize the API across router types? It's really limiting for us though and I'm not seeing any alternative to access the history's entries.

@mjackson @pshrmn @timdorr

@FabianMeul
Copy link

FabianMeul commented Dec 22, 2021

Also wondering why entries are not exposed on MemoryRouter.
Just like @fdecampredon, I want to render the previous route but without access to the entries it leaves only manually tracking the entries... (and duplicating what's already in history)

@mjackson @pshrmn @timdorr

@quiram
Copy link

quiram commented Jan 9, 2022

In case it helps with the decision, we currently use history.entries to adjust the text in the back links of our web application. I understand that exposing the entries perhaps wasn't initially thought of as a feature but it looks like it's becoming one that people depend on.

@Nantris
Copy link

Nantris commented Jan 10, 2022

We're totally dependent on it. We had no idea that we were looking at an impossible upgrade path by using properties which were exposed without any warning that they'd disappear in the future.

@Donorlin
Copy link

Any news about this, please?

@Nantris
Copy link

Nantris commented Mar 10, 2022

Anyone following this should take a look at #939 submitted by @Donorlin. A big thanks to @Donorlin for creating the PR!

@Nantris
Copy link

Nantris commented Apr 12, 2022

Bump.

@trungutt
Copy link

trungutt commented Jul 3, 2023

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants