[Bug]: Upgrading from 6.4.3 to 6.4.4 breaks our application

[victorcarvalhosp]

What version of React Router are you using?

6.4.4

Steps to Reproduce

We have a Figma extension that runs inside an iframe and using version 6.4.3 or lower it works just fine. But as soon we update to 6.4.4 or higher it doesn't work anymore.

If we switch from <HashRouter> to <MemoryRouter> the error is not thrown, but the router simply doesn't work. We modified the Routes path accordingly to the documentation and it still doesn't work.

We didn't expect a minor version upgrade to break our application, and we haven't found a way around this error so far, so any help will be very much appreciated!

Expected Behavior

updating from 6.4.3 to 6.4.4 or higher version should work fine as it's not a breaking change

Actual Behavior

Everything works fine on version 6.4.3 - but as soon as we update to 6.4.4 or higher we start to see this error message:

VM538:34045 Uncaught TypeError: Failed to construct 'URL': Invalid URL
    at createURL (<anonymous>:34045:10)
    at Object.encodeLocation (<anonymous>:34139:17)
    at NavLinkWithRef (<anonymous>:147921:57)
    at renderWithHooks (<anonymous>:132022:18)
    at updateForwardRef (<anonymous>:134938:20)
    at beginWork (<anonymous>:137348:16)
    at HTMLUnknownElement.callCallback (<anonymous>:119881:14)
    at HTMLUnknownElement.sentryWrapped (<anonymous>:37690:17)
    at Object.invokeGuardedCallbackDev (<anonymous>:119930:16)
    at invokeGuardedCallback (<anonymous>:119994:31)
    at beginWork$1 (<anonymous>:143163:7)
    at performUnitOfWork (<anonymous>:142272:12)
    at workLoopSync (<anonymous>:142178:5)
    at renderRootSync (<anonymous>:142146:7)
    at performConcurrentWorkOnRoot (<anonymous>:141450:74)
    at workLoop (<anonymous>:156223:34)
    at flushWork (<anonymous>:156196:14)
    at MessagePort.performWorkUntilDeadline (<anonymous>:156490:21)

[timdorr]

This is most likely caused by #9682, though that is a valid fix. Instead, we probably need to check for window.parent or something like that.

[brophdawg11]

Would you be able to provide more information on the specific URL that's throwing this error by either adding a debugger or a logpoint? Presumably the error is coming from this line so knowing what window looks like at that point would be useful: https://github.com/remix-run/react-router/blob/main/packages/router/history.ts#L676

[brophdawg11]

I'm going to close this out as stale, but please re-open with a reproduction if this is still an issue

[victorcarvalhosp]

@brophdawg11

Would you be able to provide more information on the specific URL that's throwing this error by either adding a debugger or a logpoint? Presumably the error is coming from this line so knowing what window looks like at that point would be useful: https://github.com/remix-run/react-router/blob/main/packages/router/history.ts#L676

Sorry for the long delay in replying here again. This is what I get if I log the document.URL or window.location.href:
data:text/html;base64,PHNjcmlwdD4KICAgICAgb25tZXNzYWdlID0gKGV2ZW50KSA9PiB7CiAgICAgICAgaWYgKGV2ZW50LnNvdXJjZSA9PT0gd2luZG93LnBhcmVudC5wYXJlbnQucGFyZW50ICYmIGV2ZW50Lm9yaWdpbiA9PT0gImh0dHBzOi8vd3d3LmZpZ21hLmNvbSIpIHsKICAgICAgICAgIGRvY3VtZW50LndyaXRlKCI8c2NyaXB0PiIgKyAiXG4gZG9jdW1lbnQuY2xvc2UoKTtcbiBkb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCdrZXlkb3duJywgKGUpID0+IHtcbiAgIGlmIChlLmtleUNvZGUgPT09IDgwIC8qIFAgKi8gJiYgIWUuc2hpZnRLZXkgJiYgZS5hbHRLZXkgJiYgIWUuY3RybEtleSAmJiBlLm1ldGFLZXkpIHtcbiAgICAgLy8gSGFuZGxlIHRoZSBwbHVnaW4gcmUtcnVuIHNob3J0Y3V0XG4gICAgIHdpbmRvdy5wYXJlbnQucG9zdE1lc3NhZ2UoJyRJTlRFUk5BTF9ET19OT1RfVVNFJFJFUlVOX1BMVUdJTiQnLCAnKicpXG4gICAgIGUuc3RvcFByb3BhZ2F0aW9uKClcbiAgICAgZS5zdG9wSW1tZWRpYXRlUHJvcGFnYXRpb24oKVxuICAgfSBlbHNlIGlmICh0cnVlKSB7XG4gICAgIC8vIEhhbmRsZSBTZWxlY3QgQWxsLCBVbmRvIGFuZCBSZWRvIGluIHRoZSBkZXNrdG9wIGFwcFxuICAgICBjb25zdCBjdHJsRG93biA9IGUubWV0YUtleVxuICAgICBpZiAoY3RybERvd24pIHtcbiAgICAgICBpZiAoZS5rZXlDb2RlID09PSA2NSAvKiBBICovKSB7XG4gICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgnc2VsZWN0QWxsJylcbiAgICAgICB9IGVsc2UgaWYgKGUua2V5Q29kZSA9PT0gOTAgLyogWiAqLykge1xuICAgICAgICAgaWYgKGUuc2hpZnRLZXkpIHtcbiAgICAgICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ3JlZG8nKVxuICAgICAgICAgfSBlbHNlIHtcbiAgICAgICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ3VuZG8nKVxuICAgICAgICAgfVxuICAgICAgIH0gZWxzZSBpZiAoKGUua2V5ID09PSAneCcgfHwgZS5rZXkgPT09ICdYJykgJiYgZmFsc2UpIHtcbiAgICAgICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCdjdXQnKVxuICAgICAgIH0gZWxzZSBpZiAoKGUua2V5ID09PSAnYycgfHwgZS5rZXkgPT09ICdDJykgJiYgZmFsc2UpIHtcbiAgICAgICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCdjb3B5JylcbiAgICAgICB9IGVsc2UgaWYgKChlLmtleSA9PT0gJ3YnIHx8IGUua2V5ID09PSAnVicpICYmIGZhbHNlKSB7XG4gICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgncGFzdGUnKVxuICAgICAgIH1cbiAgICAgfVxuICAgfVxuIH0sIHRydWUpXG5cbiBmdW5jdGlvbiByZW5kZXJDc3NWYXJpYWJsZXModmFycykge1xuICAgcmV0dXJuIE9iamVjdC5lbnRyaWVzKHZhcnMpXG4gICAgIC5tYXAoKGVudHJ5KSA9PiBlbnRyeS5qb2luKCc6ICcpKVxuICAgICAuam9pbignOyAnKSArICc7J1xuIH1cblxuIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdtZXNzYWdlJywgZnVuY3Rpb24oZXZlbnQpIHtcbiAgIGlmIChcbiAgICAgZXZlbnQuc291cmNlID09PSB3aW5kb3cucGFyZW50LnBhcmVudC5wYXJlbnQgJiZcbiAgICAgZXZlbnQuZGF0YSAmJlxuICAgICB0eXBlb2YgZXZlbnQuZGF0YSA9PT0gJ29iamVjdCcgJiZcbiAgICAgJ2ZpZ21hTWVzc2FnZScgaW4gZXZlbnQuZGF0YVxuICAgKSB7XG4gICAgIGV2ZW50LnN0b3BJbW1lZGlhdGVQcm9wYWdhdGlvbigpXG5cbiAgICAgY29uc3QgZmlnbWFNZXNzYWdlID0gZXZlbnQuZGF0YS5maWdtYU1lc3NhZ2VcblxuICAgICBpZiAoZmlnbWFNZXNzYWdlLnR5cGUgPT09ICdUSEVNRScpIHtcbiAgICAgICBjb25zdCBmaWdtYVN0eWxlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2ZpZ21hLXN0eWxlJylcbiAgICAgICBmaWdtYVN0eWxlLnRleHRDb250ZW50ID0gJzpyb290IHsgJyArIHJlbmRlckNzc1ZhcmlhYmxlcyhmaWdtYU1lc3NhZ2UucGF5bG9hZC52YXJpYWJsZXMpICsgJyB9J1xuXG4gICAgICAgY29uc3QgY2xhc3Nlc1RvUmVtb3ZlID0gW11cblxuICAgICAgIGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5jbGFzc0xpc3QuZm9yRWFjaCgodmFsdWUpID0+IHtcbiAgICAgICAgIGlmICh2YWx1ZS5zdGFydHNXaXRoKCdmaWdtYS0nKSkge1xuICAgICAgICAgICBjbGFzc2VzVG9SZW1vdmUucHVzaCh2YWx1ZSlcbiAgICAgICAgIH1cbiAgICAgICB9KVxuXG4gICAgICAgZm9yIChjb25zdCBjbGFzc05hbWUgb2YgY2xhc3Nlc1RvUmVtb3ZlKSB7XG4gICAgICAgICBkb2N1bWVudC5kb2N1bWVudEVsZW1lbnQuY2xhc3NMaXN0LnJlbW92ZShjbGFzc05hbWUpXG4gICAgICAgfVxuXG4gICAgICAgaWYgKGZpZ21hTWVzc2FnZS5wYXlsb2FkLm5hbWUgJiYgZmlnbWFNZXNzYWdlLnBheWxvYWQubmFtZSAhPT0gJ2xlZ2FjeScpIHtcbiAgICAgICAgIGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5jbGFzc0xpc3QuYWRkKCdmaWdtYS0nICsgZmlnbWFNZXNzYWdlLnBheWxvYWQubmFtZSlcbiAgICAgICB9XG4gICAgIH1cbiAgIH1cbiB9LCB0cnVlKVxuICIgKyAiIiArICJcbiAgICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ3NlY3VyaXR5cG9saWN5dmlvbGF0aW9uJywgKGV2ZW50KSA9PiB7XG4gICAgICAgICAgdHJ5IHtcbiAgICAgICAgICAgIGNvbnN0IHVybCA9IG5ldyBVUkwoZXZlbnQuYmxvY2tlZFVSSSlcbiAgICAgICAgICAgIGNvbnNvbGUud2FybignRmFpbGVkIHRvIGxvYWQgcmVzb3VyY2UgZnJvbScsIGV2ZW50LmJsb2NrZWRVUkksICdzaW5jZSBpdCBpcyBub3QgaW4gdGhlIGxpc3Qgb2YgYWxsb3dlZCBkb21haW5zLiBQbGVhc2UgYWRkJywgJ1wiJyArIHVybC5vcmlnaW4gKyAnXCInLCAndG8gdGhlIG5ldHdvcmtBY2Nlc3MgPiBhbGxvd2VkRG9tYWlucyBmaWVsZCBpbiB5b3VyIG1hbmlmZXN0Lmpzb24uJylcbiAgICAgICAgICB9IGNhdGNoIHtcbiAgICAgICAgICAgIC8vIFRoaXMgaXMgdG8gbWFrZSBzdXJlIHdlIGRvbid0IGNyYXNoIGlmIHRoZSBibG9ja2VkVVJJIGlzIG5vdCBhIHZhbGlkIFVSTC5cbiAgICAgICAgICAgIC8vIFRoaXMgc2hvdWxkIG5ldmVyIGhhcHBlbiBzaW5jZSB3ZSdyZSBnZXR0aW5nIHRoZSB1cmwgZnJvbSB0aGUgV2ViIEFQSSwgYnV0IGJldHRlciBzYWZlIHRoYW4gc29ycnkuXG4gICAgICAgICAgfVxuICAgICAgICB9KSIgKyAiPC8iICsgInNjcmlwdD4iICsgZXZlbnQuZGF0YSkKICAgICAgICB9CiAgICAgIH0KCiAgPC9zY3JpcHQ+

I'm going to close this out as stale, but please re-open with a reproduction if this is still an issue

I'm sorry I can't create a reproduction as it just happens when running inside Figma(as it's a Figma extension)

EDIT: This time after switching from HashRouter to MemoryRouter our application is working fine. So we're moving ahead with MemoryRouter