Use history.createLocation for converting location descriptors to locations

[taion]

transitionManager.isActive:
This logic is wrong and should go through history.createLocation: https://github.com/rackt/react-router/blob/3494ed3974020b42c9af9490d681877829f3e9e1/modules/createTransitionManager.js#L37-L39

match:
Should be using history.createLocation in all cases: https://github.com/rackt/react-router/blob/3494ed3974020b42c9af9490d681877829f3e9e1/modules/match.js#L30-L31

Blocked on remix-run/history#200.

[taion]

match is handling this wrong too – updated the OP.

[taion]

Huh, the naive isActive fix will actually break #2386. Need to think about this a bit.

[seoyoochan]

I just followed ^2.0.0-rc upgrade guide documentation, using "history": "^2.0.0-rc2" and "react-router": "^1.0.3".
However, I get this error,
Uncaught TypeError: Cannot read property 'query' of undefined

My code looks like this..

function requireAuth(nextState, replace) {
  const isLoggedIn = store.getState().auth.isLoggedIn;
  if (isLoggedIn) {
    console.log('Verified User.');
  } else {
    replace('/login');
  }
}

const routes = (
  <Provider store={store}>
    <Router history={browserHistory}>
      <Route path='/' component={App} onEnter={requireAuth}>
        <IndexRoute component={Dashboard}/>
        <Route path='login' component={Login}/>
      </Route>
    </Router>
  </Provider>
);

Is this a bug? how can I solve this?

[taion]

See #2897.

[seoyoochan]

@taion thanks for the answer, but i get this infinite redirection error, Uncaught RangeError: Maximum call stack size exceeded though. is there any workaround for this?

Never mind! It was my problem, I had to move onEnter hook to IndexRoute!

[taion]

Closing this to track #2910 instead.