An invalid URI will make react-router crash

[pucka]

Version

2.4.0

Test Case

http://codepen.io/anon/pen/VjYREm

Steps to reproduce

Use any non-valid UTF-8-encoded character sequence in the URI

Expected Behavior

This one is hard. I think you want react-router just to ignore the faulty values

Actual Behavior

react-router crashes making your site crash

[aweary]

This error is thrown by the query-string which is used by history to parse URIs. Ignoring the faulty values in react-router would be dependent on that package being able to return the valid portions of the URI, as far as I can tell.

[pucka]

Yes, that's one of the two cases. The second case, when the pathname is invalid, the error is thrown in react routers PatternUtils using decodeURIComponent

[timdorr]

You can provide your own query string parsing methods, which can work around this. It's really an upstream issue with query-string, so I would file an issue there.

[pucka]

Ok, i'll do that. But it still breaks in react-routers own library @ https://github.com/reactjs/react-router/blob/master/modules/PatternUtils.js#L120 not related to query-string

May not be a case if you take care of this server side, but it's still breaks on client side.

[taion]

Alternatively, catch the error and hit the error callback, as with #3453 – we'd be happy to accept a PR that does that (if it works, &c.)