Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - onEnter callback don't passing error to match callback #4114

Closed
arkist opened this issue Oct 28, 2016 · 1 comment
Closed

v3 - onEnter callback don't passing error to match callback #4114

arkist opened this issue Oct 28, 2016 · 1 comment

Comments

@arkist
Copy link
Contributor

arkist commented Oct 28, 2016

Version

3.0.0

Test Case

💖

Steps to reproduce

<someRouter onEnter=(nextState, replace, callback) => {
  callback(new Error('error!');
}/>

match({router, location}, (error, redirect, renderProps) => {
  console.error(error); // null
});

Expected Behavior

match callback should catch error if onEnter callback passing error.

Actual Behavior

on match's callback, error is null

it seems #4063 causing this. 🤔

@timdorr
Copy link
Member

timdorr commented Oct 31, 2016

Thanks for reporting! Let's track this in #4123

@timdorr timdorr closed this as completed Oct 31, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants