Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revival of location.query in location object #5292

Closed
ZeroCho opened this issue Jun 28, 2017 · 1 comment
Closed

revival of location.query in location object #5292

ZeroCho opened this issue Jun 28, 2017 · 1 comment

Comments

@ZeroCho
Copy link

ZeroCho commented Jun 28, 2017

Currently, we can access query string by location.search
I think it would be better to provide location.query which excludes ? from location.search.

For example, assume that we have a url like 'www.reactrouter.com?type=web',
location.search shows '?type=web'

and I request to have
location.query which shows 'type=web' without '?' letter.

Node.js url module also provide both location.search and location.query.
I think providing both is useful for those who parse querystring. For me, I always have to substring url to exclude ? letter, and it's quite annoying.

@timdorr
Copy link
Member

timdorr commented Jun 28, 2017

Please see #4410. In particular, see this comment: #4410 (comment)

@timdorr timdorr closed this as completed Jun 28, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants