Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link and NavLink also push location to location stack when the current location is already the linked location #6137

Closed
vince1995 opened this issue May 8, 2018 · 1 comment
Closed

Link and NavLink also push location to location stack when the current location is already the linked location #6137

vince1995 opened this issue May 8, 2018 · 1 comment

Comments

@vince1995
Copy link

Version

4.2.2

Steps to reproduce

Be on your website with something like a navigation bar. Click on a link which refers to the location where you're staying.

Expected Behavior

It shouldn't push a new location to the location stack.

Actual Behavior

It pushes a new location to the location stack.
@timdorr
Copy link
Member

timdorr commented May 8, 2018

remix-run/history#470

@timdorr timdorr closed this as completed May 8, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timdorr @vince1995