Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6] Routers could accept history as optional prop #7671

Closed
Bekaxp opened this issue Oct 26, 2020 · 1 comment
Closed

[v6] Routers could accept history as optional prop #7671

Bekaxp opened this issue Oct 26, 2020 · 1 comment

Comments

@Bekaxp
Copy link

Bekaxp commented Oct 26, 2020

Issue

We have a widget system where the history needs to be shared between all of them. Currently the new Routers (Browser, Hash and Memory) do not have any option to pass an already existent history, which will be used instead of always creating a new one.

Suggestion

Is there a good reason why not extend these Routers with an additional history prop, which will be used in the following lines:

Thank you.

@timdorr
Copy link
Member

timdorr commented Oct 26, 2020

Duplicate of #7585 and has a PR open to resolve this: #7586

@timdorr timdorr closed this as completed Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants