Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Rename @remix-run/architect adapter to @remix-run/aws-lambda #1038

Closed
shamsup opened this issue Dec 14, 2021 · 0 comments
Closed

Comments

@shamsup
Copy link
Contributor

shamsup commented Dec 14, 2021

What is the new or updated feature that you are suggesting?

  1. I think it would be beneficial in the long run to rename this adapter to @remix-run/aws-lambda to avoid confusion.
  2. Remove the peer dependency on @architect/architect since it is not used

Why should this feature be included?

  1. The @remix-run/architect adapter is actually a generic adapter for AWS Lambda behind API Gateway. This package can be used as the adapter for projects using AWS CDK, AWS SAM, and serverless framework in addition to architect (and lambda without a framework).
  2. Currently, the architect adapter has no need for a peer dependency of architect because it is not used within the package.

I think this will avoid confusion moving forward for people who want to run Remix within AWS Lambda but are using another framework to work with the service.

@remix-run remix-run locked and limited conversation to collaborators Aug 2, 2022
@machour machour converted this issue into discussion #3905 Aug 2, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants